Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remote rules #4698

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Aug 19, 2020

in order to iterate quickly over error recommendations and suggestions I added remote rules.
However, after talking to the team, we felt this is not the right direction and we should target suggestions to be part of a release.

Removing these rules.

@tejal29 tejal29 requested a review from a team as a code owner August 19, 2020 06:59
@tejal29 tejal29 requested a review from briandealwis August 19, 2020 06:59
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #4698 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4698      +/-   ##
==========================================
+ Coverage   73.18%   73.30%   +0.11%     
==========================================
  Files         340      338       -2     
  Lines       13372    13357      -15     
==========================================
+ Hits         9786     9791       +5     
+ Misses       2979     2961      -18     
+ Partials      607      605       -2     
Impacted Files Coverage Δ
pkg/diag/validator/pod.go 1.67% <100.00%> (-1.09%) ⬇️
pkg/skaffold/deploy/status_check.go 59.06% <100.00%> (+0.78%) ⬆️
pkg/skaffold/deploy/kpt.go 89.47% <0.00%> (-10.53%) ⬇️
pkg/skaffold/runner/build_deploy.go 72.27% <0.00%> (+0.36%) ⬆️
pkg/skaffold/schema/validation/validation.go 95.20% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72560a3...40c172a. Read the comment docs.

@tejal29 tejal29 merged commit 035c89f into GoogleContainerTools:master Aug 19, 2020
@briandealwis
Copy link
Member

LGTM

I didn't realize this existed :-) What's nice about these external rules is they provide a way to accommodate front-end-specific actionable suggestions (e.g., if we have a diag command, or a different front-end for GCB etc.).

nkubala pushed a commit to nkubala/skaffold that referenced this pull request Aug 20, 2020
nkubala pushed a commit to nkubala/skaffold that referenced this pull request Aug 20, 2020
@tejal29 tejal29 deleted the remove_remote_rules branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants