Add Kustomize Hydration to Kpt Deployer's Render method #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4719 +/- ##
==========================================
+ Coverage 73.38% 73.42% +0.04%
==========================================
Files 341 342 +1
Lines 13505 13560 +55
==========================================
+ Hits 9910 9957 +47
- Misses 2976 2980 +4
- Partials 619 623 +4
Continue to review full report at Codecov.
|
yuwenma
reviewed
Aug 26, 2020
yuwenma
reviewed
Aug 26, 2020
yuwenma
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3904, #4708
Description
This PR builds upon the existing render method for the Kpt Deployer in #4708 by adding the remaining steps for the desired hydration workflow. This includes reading config manifests from the source directory and running
kustomize buildwhen kustomization configs exist under the specified directory (k.Dir).Currently, a temporary directory called .pipeline is used to store outputs between different stages of the rendering process. This directory will be replaced by sinkDir when specified by the user.
There is also a slight modification to the kptFnRun method for checking whether FnPath and Image are both provided. This was discussed in further detail in #4708.