Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow test #4740

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Fix slow test #4740

merged 2 commits into from
Aug 31, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 31, 2020

No description provided.

dgageot added 2 commits August 31, 2020 14:45
@dgageot
Fix slow test
1cf6fa8 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Use k8s client as a last resort
512d6cd 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot requested a review from a team as a code owner August 31, 2020 12:47
@dgageot dgageot requested a review from briandealwis August 31, 2020 12:47
@codecov
Copy link

codecov bot commented Aug 31, 2020 •
edited
Loading

Codecov Report

Merging #4740 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4740   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         345      345           
  Lines       13739    13739           
=======================================
  Hits        10085    10085           
  Misses       3021     3021           
  Partials      633      633
Impacted Files Coverage Δ
pkg/skaffold/config/util.go 69.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ec899...512d6cd. Read the comment docs.

@gsquared94 gsquared94 merged commit 89306fd into GoogleContainerTools:master Aug 31, 2020
@fmotrifork fmotrifork mentioned this pull request Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsquared94 gsquared94 gsquared94 approved these changes

@briandealwis briandealwis Awaiting requested review from briandealwis

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @gsquared94 @googlebot