-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation - CI/CD Tutorial End to End with Skaffold #4909
Conversation
Hi. Have added all the contents for the tutorial here. Do let me know if you need anything else. Regards, Vignesh T.V.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## master #4909 +/- ##
==========================================
+ Coverage 71.96% 72.18% +0.22%
==========================================
Files 357 365 +8
Lines 12327 12842 +515
==========================================
+ Hits 8871 9270 +399
- Misses 2799 2881 +82
- Partials 657 691 +34
Continue to review full report at Codecov.
|
Please take a look @viglesiasce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR @tvvignesh! I've taken a first pass at it, mostly just commenting on nits related to readability and language, not so much on content. Let me know what you think of my suggestions :)
Applied the suggestions as given to the doc. Co-authored-by: Marlon Gamez <marlongamez@google.com>
@MarlonGamez Thanks a lot for your suggestions. Have made all the necessary changes. Let me know if there is anything else to be done. |
Thanks @tvvignesh And @MarlonGamez for taking this forward! |
@tvvignesh thanks a bunch for making the changes :) One thing I would say is that I think the step labels should be h2s (like step 6 was previously), just to make a bit more clear where each step starts |
I will spend sometime next week on this and try to do a rewrite taking into account @briandealwis 's suggestions. Please leave all your suggestions here. Thanks. |
hey @tvvignesh, have you had the chance to work on this a bit? No rush, just curious :) thanks again for working on this! |
@briandealwis @MarlonGamez Hi. Pushed the changes. Have tried to address all the feedback as given above. Hope this is okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in interest of not blocking this indefinitely, let's merge it for now and we can make edits later as we need them.
this would be a great addition to #5031 if it ever gets created.
thanks for all your work on this one @tvvignesh!
@nkubala Forgot to inform this. I did not update |
Fixes: #346
Description
This PR add documentation for CI/CD end to end with skaffold