Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description of some kaniko flags #4988

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fix description of some kaniko flags #4988

merged 1 commit into from
Nov 3, 2020

Conversation

ricardo-larosa
Copy link
Contributor

Description

Fixes the description of kaniko flags:

  • digestFile
  • imageNameWithDigestFile
  • registryCertificate

@ricardo-larosa ricardo-larosa requested a review from a team as a code owner November 2, 2020 21:23
@google-cla google-cla bot added the cla: yes label Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020 •
edited
Loading

Codecov Report

Merging #4988 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4988   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files         362      362           
  Lines       12717    12717           
=======================================
  Hits         9181     9181           
  Misses       2855     2855           
  Partials      681      681
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18af134...fdbb662. Read the comment docs.

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Nov 2, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 2, 2020
IsaacPD
IsaacPD approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@IsaacPD IsaacPD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@IsaacPD IsaacPD merged commit f9010a6 into GoogleContainerTools:master Nov 3, 2020
@ricardo-larosa ricardo-larosa deleted the fix-typos-kaniko-desc branch November 3, 2020 09:40
@fmotrifork fmotrifork mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacPD IsaacPD IsaacPD approved these changes

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricardo-larosa @IsaacPD @tejal29 @kokoro-team