Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker CLI tests faster by mocking the call to docker auth #5060

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Nov 24, 2020

Before, on master

ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/docker	46.868s
=== Slow Tests ===
37.05s	TestDockerCLIBuild
8.05s	TestDockerCLIBuild/docker_build
8.04s	TestDockerBuildError
8.03s	TestDockerBuildError/docker_file_present
7.67s	TestDockerCLIBuild/extra_env
7.55s	TestDockerCLIBuild/buildkit
6.91s	TestDockerCLIBuild/buildkit_and_extra_env
6.87s	TestDockerCLIBuild/env_var_collisions
4.44s	TestGetAllAuthConfigs

After this change,

ok  	github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/docker	1.453s

/cc @marlon-gamez

@tejal29 tejal29 requested a review from a team as a code owner November 24, 2020 23:14
@tejal29 tejal29 requested a review from MarlonGamez November 24, 2020 23:14
@google-cla google-cla bot added the cla: yes label Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5060 (9c63f38) into master (3fe0c99) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5060      +/-   ##
==========================================
+ Coverage   72.27%   72.29%   +0.02%     
==========================================
  Files         368      368              
  Lines       12914    12914              
==========================================
+ Hits         9333     9336       +3     
+ Misses       2890     2889       -1     
+ Partials      691      689       -2     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 80.93% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe0c99...9c63f38. Read the comment docs.

@MarlonGamez
Copy link
Contributor

nice! Thanks for this :) I'll approve once CI passes

@tejal29 tejal29 merged commit d4b2a1c into GoogleContainerTools:master Nov 25, 2020
@tejal29 tejal29 mentioned this pull request Nov 26, 2020
@tejal29 tejal29 deleted the make_unit_tests_fatsre branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants