Deleting unexpected lines #5131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a test in a previous PR, this file was modified with some lines included. Those lines should not be there.
Codecov Report
@@ Coverage Diff @@
## master #5131 +/- ##
=======================================
Coverage 72.19% 72.19%
=======================================
Files 381 381
Lines 13543 13543
=======================================
Hits 9777 9777
Misses 3050 3050
Partials 716 716 Continue to review full report at Codecov.
|
zedfmario
referenced
this pull request
Dec 10, 2020
) * enabling using another container's network stack on build process Building docker images in a Jenkins-like environment running on a AWS EKS cluster secured with `kube2iam` requires the running pod to include an annotation. In our particular case, we share the docker daemon from the node with the running pod by mounting the socket as a volume. When `skaffold` builds a new image within this pod, it creates containers at node level due to the shared socket. Therefore, to have a brand new container handled by `kube2iam`, this container should reuse the pod's network stack –ergo the "pause" container's stack–. Enabling the use of `container:<name|id>` network mode from `docker run` command. It allows a build process to reuse another container's stack. > Described in [here](https://docs.docker.com/engine/reference/run/#network-settings) * Adapting REGEXP to docker requirements According to the `docker` CLI, when running a container with a wrong name, the following output is shown: ``` > docker run -it --name '$$' alpine docker: Error response from daemon: Invalid container name ($$), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed. ``` Concatenating `container:` to the expected regular expression `[a-zA-Z0-9][a-zA-Z0-9_.-]` helps us rejecting wrong values. * runtime validation for docker network stack sharing * overriding docker local daemon in tests * validation with run context unified better testing allows to unify methods * adding skaffold error handling * removing unnecessary dependency
briandealwis
approved these changes
Dec 10, 2020
|
@briandealwis, thx for merging this Regarding the tutorial, open an issue and assign it to me. I'll gladly make it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tejal29
Fixes: #5087
Caused bY: #5088
Check this comment
Description
Due to a test in a previous PR, this file was modified with some lines included.
Those lines should not be there.