Ensure init generates /-delimted paths #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5177 +/- ##
==========================================
+ Coverage 71.82% 71.88% +0.05%
==========================================
Files 387 387
Lines 13928 13931 +3
==========================================
+ Hits 10004 10014 +10
+ Misses 3190 3187 -3
+ Partials 734 730 -4
Continue to review full report at Codecov.
|
briandealwis
force-pushed
the
slashes-only
branch
from
38a0458 to
322fb32
Compare
briandealwis
requested review from
chanseokoh,
loosebazooka and
a team
as code owners
|
this LGTM, I can approve and merge once we get our ci issues resolved |
IsaacPD
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5074
Description
Ensure paths are written using forward slashes during
init. Adds a test for Windows.The choice of where to maintain and use the workspace is a bit confusing.
ArtifactConfigto capture a detected artifact (e.g., Jib).ArtifactConfigimplements aninitializers/build.InitBuilderinterface. TheArtifactType()method generates a config schema'sArtifactTypewith the appropriate per- builder information. ThisArtifactTypeis contained with the artifact's workspace within the config schema'sArtifactobject.For now I pass the workspace into the per-builder
ArtifactConfig.ArtifactType(workspace)functions. It would seem to make sense for the workspace to be passed around within the per-builderArtifactConfigobjects, except that they don't actually generate theArtifactobject. So we'd still need to swizzle the workspace when creating the correspondingArtifactobjects.But it might be worth having the
ArtifactConfigobjects be responsible for generating theArtifactobject so that they could populate it with sync rules?