Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes on documents #5211

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Conversation

ssbostan
Copy link
Contributor

@ssbostan ssbostan commented Jan 7, 2021

for updating documents as well

skaffold.yaml was found exit code is 103 and now corrected.
its better to use same name as used in cli command.
@ssbostan ssbostan requested a review from a team as a code owner January 7, 2021 09:09
@ssbostan ssbostan requested a review from ilya-zuyev January 7, 2021 09:09
@google-cla
Copy link

google-cla bot commented Jan 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 7, 2021
@ssbostan
Copy link
Contributor Author

ssbostan commented Jan 7, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #5211 (611a19b) into master (b5ccab5) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5211      +/-   ##
==========================================
+ Coverage   71.82%   71.85%   +0.02%     
==========================================
  Files         387      387              
  Lines       13928    13928              
==========================================
+ Hits        10004    10008       +4     
+ Misses       3190     3188       -2     
+ Partials      734      732       -2     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ccab5...611a19b. Read the comment docs.

@IsaacPD IsaacPD added docs-modifications runs the docs preview service on the given PR kokoro:run runs the kokoro jobs on a PR labels Jan 7, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 7, 2021
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 7, 2021
@container-tools-bot

This comment has been minimized.

@IsaacPD IsaacPD added the docs-modifications runs the docs preview service on the given PR label Jan 7, 2021
@container-tools-bot
Copy link

Please visit http://34.94.116.224:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jan 7, 2021
@MarlonGamez
Copy link
Contributor

hey @ssbostan, thanks for these doc fixes! We're having some CI issues right now, but once we resolve them I think we can approve and merge this :)

@ssbostan
Copy link
Contributor Author

ssbostan commented Jan 7, 2021

Hey there @MarlonGamez, your welcome, i read all of documents and will be fix another issues too.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@briandealwis briandealwis merged commit 71d001b into GoogleContainerTools:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants