Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include commands and directory in run output #5254

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

briandealwis
Copy link
Member

@briandealwis briandealwis commented Jan 20, 2021

To help diagnose issues like #5249, include the command and directory in the integration/skaffold/helper.go Run*():

time="2021-01-20T14:27:42-05:00" level=info msg="Running [skaffold diagnose] in examples/bazel"
time="2021-01-20T14:28:45-05:00" level=info msg="Ran [skaffold diagnose] in 1 minute 2.992 seconds"

Not to mention odd output like the following:

time="2021-01-20T17:21:23Z" level=info msg="[skaffold build --default-repo gcr.io/k8s-skaffold --profile kustomize]"
time="2021-01-20T17:21:23Z" level=info msg="Ran in 2 minutes 7.497 seconds"
time="2021-01-20T17:21:27Z" level=info msg="Ran in 4.173 seconds"

@briandealwis briandealwis requested a review from a team as a code owner January 20, 2021 19:33
@google-cla google-cla bot added the cla: yes label Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #5254 (0f2ad60) into master (dafb415) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5254      +/-   ##
==========================================
+ Coverage   71.87%   71.90%   +0.02%     
==========================================
  Files         388      388              
  Lines       14043    14043              
==========================================
+ Hits        10094    10098       +4     
+ Misses       3205     3203       -2     
+ Partials      744      742       -2     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dafb415...0f2ad60. Read the comment docs.

@briandealwis briandealwis merged commit 189701d into GoogleContainerTools:master Jan 20, 2021
@briandealwis briandealwis deleted the run-cmd branch January 20, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants