Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md should point to annotated-skaffold.yaml #542

Merged
merged 1 commit into from
May 14, 2018

Conversation

bryanlarsen
Copy link
Contributor

annotated-skaffold.yaml appears to be the closest thing to detailed documentation this project has, so it'd be nice to point to it from the README.

annotated-skaffold.yaml appears to be the closest thing to detailed documentation this project has, so it'd be nice to point to it from the README.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@bryanlarsen
Copy link
Contributor Author

I signed it!

@dlorenc
Copy link
Contributor

dlorenc commented May 11, 2018

I think you have to say something like "@googlebot I signed it!"

@bryanlarsen
Copy link
Contributor Author

@googlebot I signed it!

@dgageot
Copy link
Contributor

dgageot commented May 12, 2018

@bryanlarsen Are you sure your signed the CLA with the email that is attached to your GitHub account?

@bryanlarsen
Copy link
Contributor Author

My github account has three emails attached, the CLA was signed with the one marked "primary" and "visible". Of course, this PR is trivial: you're welcome to view it as a documentation request rather than a PR if the CLA stuff doesn't get sorted out.

@dlorenc
Copy link
Contributor

dlorenc commented May 14, 2018

I've manually verified it was signed by your email address/github account. We can merge.

@dlorenc dlorenc merged commit ee7be4e into GoogleContainerTools:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants