-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digest source 'tag' to use tag without digest #5436
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #5436 +/- ##
==========================================
+ Coverage 71.39% 71.42% +0.02%
==========================================
Files 397 397
Lines 14540 14553 +13
==========================================
+ Hits 10381 10394 +13
- Misses 3388 3389 +1
+ Partials 771 770 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: @tejal29 clarified this for me offline, ignore
This may be a dumb question but, what is the difference between using 'remote' vs 'tag'? Since they both go down the same code path now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit to update the comment
Co-authored-by: Marlon Gamez <marlongamez@google.com>
@tejal29 I've updated the comment as @MarlonGamez suggested, could you start another kokoro run please? |
Related: #3649
Description
A new option
skaffold render --digest-source=tag
was added, which will render the manifests with built tags. The difference between 'none' and 'tag' is that the former one will keep whatever artifacts are in the original manifests, while the latter will update them with proper tags, without sha256 digests.This could be very helpful when rendering one-for-all release manifests in multi-arch deployment scenarios, although extra cares should be taken in this case to not move any released tags.
User facing changes (remove if N/A)
User gets a new option
skaffold render --digest-source=tag