Clarify how Skaffold resolves files #5467
Conversation
briandealwis
added
docs-modifications
|
Please visit http://35.236.91.127:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
|
Error creating deployment docs-controller-deployment-5467, please visit https://storage.googleapis.com/webhook-logs/logs-5467-1614379720231026047 to view logs. |
|
Error creating deployment, please see controller logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #5467 +/- ##
==========================================
- Coverage 71.48% 71.28% -0.21%
==========================================
Files 397 400 +3
Lines 14573 14975 +402
==========================================
+ Hits 10418 10675 +257
- Misses 3387 3512 +125
- Partials 768 788 +20
Continue to review full report at Codecov.
|
| build: | ||
| artifacts: | ||
| - image: app | ||
| context: frontend |
There was a problem hiding this comment.
should we mention that if context is not explicitly defined then it's set to the CWD anyway?
| is resolved relative to the `frontend` directory (i.e., `frontend/Dockerfile`), | ||
| whereas the the Helm chart's location and its values-files are | ||
| relative to the current directory in `helm/project`. | ||
| ```yaml |
There was a problem hiding this comment.
also show the directory tree?
.
├── frontend
│ └── Dockerfile
├── helm
│ └── project
│ └── dev-values.yaml
└── skaffold.yaml
| `skaffold.yaml` in the current directory, but the location can be | ||
| overridden with the `--filename` flag. | ||
|
|
||
| ### File resolution |
There was a problem hiding this comment.
Can you add a File resolution section down below or mention here itself about configurations resolved as dependencies. The paths in those files are resolved relative to the directory containing the imported file. So it's recommended to have the skaffold.yaml file live in the root of the project and not in a nested directory.
|
Failure was due to Docker Hub |
Related: #5355
Description
Clarify where the
skaffold.yamlis expected to be found and how referenced files and directories are resolved against the current working directory, except for build artifacts.