Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move tag package outside of build #5547

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Mar 12, 2021

this code does not have anything inherently to do with build, so it doesn't need to be nested under the pkg/skaffold/build package. let's move it out.

this is a non-functional refactor.

@nkubala nkubala requested a review from a team as a code owner March 12, 2021 23:49
@google-cla google-cla bot added the cla: yes label Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #5547 (42e2307) into master (161a30e) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5547      +/-   ##
==========================================
- Coverage   71.29%   71.21%   -0.09%     
==========================================
  Files         400      400              
  Lines       14877    14934      +57     
==========================================
+ Hits        10607    10635      +28     
- Misses       3492     3511      +19     
- Partials      778      788      +10     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/util.go 77.77% <ø> (ø)
pkg/skaffold/build/build.go 85.71% <ø> (ø)
pkg/skaffold/build/builder_mux.go 34.37% <ø> (ø)
pkg/skaffold/build/cache/lookup.go 80.00% <ø> (ø)
pkg/skaffold/build/cache/retrieve.go 65.62% <ø> (ø)
pkg/skaffold/build/cache/types.go 100.00% <ø> (ø)
pkg/skaffold/build/scheduler.go 94.33% <ø> (ø)
pkg/skaffold/initializer/build/util.go 100.00% <ø> (ø)
pkg/skaffold/runner/build_deploy.go 69.23% <ø> (ø)
pkg/skaffold/runner/new.go 63.13% <ø> (-4.46%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161a30e...42e2307. Read the comment docs.

@nkubala nkubala merged commit dd936c7 into GoogleContainerTools:master Mar 16, 2021
@nkubala nkubala deleted the tag-package branch March 16, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants