Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --cache-artifacts flag for render #5652

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Apr 8, 2021

Fixes: #5560

Description

this change opens up the --cache-artifacts flag for skaffold render, allowing users to disable build caching in the event that they're performing local builds.

User facing changes (remove if N/A)
the --cache-artifacts flag can now be provided to the skaffold render command. the flag behaves the same way as it does on build - defaults to true, but can be false which disables cache checking and forces a build.

@nkubala nkubala requested a review from a team as a code owner April 8, 2021 22:22
@google-cla google-cla bot added the cla: yes label Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5652 (306a9e5) into master (bcb2eaa) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5652      +/-   ##
==========================================
- Coverage   70.54%   70.53%   -0.02%     
==========================================
  Files         410      410              
  Lines       15639    15639              
==========================================
- Hits        11033    11031       -2     
- Misses       3793     3794       +1     
- Partials      813      814       +1     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 88.60% <ø> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 85.40% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb2eaa...306a9e5. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 5e2a4ec into GoogleContainerTools:master Apr 12, 2021
@nkubala nkubala deleted the render-cache branch April 13, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render should support the --cache-artifacts flag
3 participants