Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workspace to tests. #5677

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

PriyaModali
Copy link
Contributor

@PriyaModali PriyaModali commented Apr 14, 2021

Adding workspace to tests.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #5677 (127c5d8) into master (f156163) will decrease coverage by 0.02%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
- Coverage   70.69%   70.66%   -0.03%     
==========================================
  Files         411      411              
  Lines       15809    15797      -12     
==========================================
- Hits        11176    11163      -13     
  Misses       3812     3812              
- Partials      821      822       +1     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 58.82% <ø> (ø)
pkg/skaffold/schema/defaults/defaults.go 86.66% <50.00%> (-0.92%) ⬇️
pkg/skaffold/test/test_factory.go 69.56% <50.00%> (ø)
pkg/skaffold/test/custom/custom.go 60.22% <100.00%> (ø)
pkg/skaffold/test/structure/structure.go 90.69% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/cluster/minikube.go 68.62% <0.00%> (-3.02%) ⬇️
pkg/skaffold/docker/parse.go 85.40% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f156163...127c5d8. Read the comment docs.

@PriyaModali PriyaModali changed the title Adding woskspace to testcase. Adding workspace to tests. Apr 14, 2021
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 15, 2021
@PriyaModali PriyaModali marked this pull request as ready for review April 15, 2021 00:25
@PriyaModali PriyaModali requested a review from a team as a code owner April 15, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants