-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add host support for docker build #5698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wuxingzhong Thank you for the PR.
Please review the "Making config changes" section in the DEVELOPMENT.md to fix the failing tests.
The code changes look good.
Codecov Report
@@ Coverage Diff @@
## master #5698 +/- ##
==========================================
+ Coverage 70.41% 70.43% +0.01%
==========================================
Files 413 413
Lines 15946 15948 +2
==========================================
+ Hits 11229 11233 +4
+ Misses 3884 3883 -1
+ Partials 833 832 -1
Continue to review full report at Codecov.
|
@wuxingzhong I pushed the config version changes in a separate PR. I think you can simplify this PR back to only your set of changes (rebased on master HEAD). |
add host support from docker build