Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host support for docker build #5698

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

wuxingzhong
Copy link
Contributor

add host support from docker build

@wuxingzhong wuxingzhong requested a review from a team as a code owner April 16, 2021 09:20
@google-cla google-cla bot added the cla: yes label Apr 16, 2021
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2021
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuxingzhong Thank you for the PR.
Please review the "Making config changes" section in the DEVELOPMENT.md to fix the failing tests.

The code changes look good.

@wuxingzhong wuxingzhong changed the title add host support from docker build add host support for docker build Apr 17, 2021
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #5698 (4f56af8) into master (bf8685a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5698      +/-   ##
==========================================
+ Coverage   70.41%   70.43%   +0.01%     
==========================================
  Files         413      413              
  Lines       15946    15948       +2     
==========================================
+ Hits        11229    11233       +4     
+ Misses       3884     3883       -1     
+ Partials      833      832       -1     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 58.82% <ø> (ø)
pkg/skaffold/docker/image.go 78.34% <100.00%> (+0.20%) ⬆️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8685a...4f56af8. Read the comment docs.

@wuxingzhong wuxingzhong requested a review from tejal29 April 19, 2021 00:58
@gsquared94
Copy link
Contributor

gsquared94 commented Apr 19, 2021

@wuxingzhong I pushed the config version changes in a separate PR. I think you can simplify this PR back to only your set of changes (rebased on master HEAD).

@wuxingzhong wuxingzhong reopened this Apr 20, 2021
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Apr 20, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 20, 2021
@tejal29 tejal29 merged commit 6c747fc into GoogleContainerTools:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants