-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for RPC port detection #5715
Added fix for RPC port detection #5715
Conversation
Test plan: `make test` Also go locally, and run multiple version of skaffold, ensure that none of them have issues with starting up their own RPC server.
This is my first PR for skaffold so any review comments are much appreciated. I know also #5590 so would be nice if we can confirm that on Windows machine this will not cause any regression (hopefully shouldn't do - it was a revert to previous behaviour for GRPC). |
Codecov Report
@@ Coverage Diff @@
## master #5715 +/- ##
==========================================
- Coverage 70.87% 70.85% -0.03%
==========================================
Files 421 421
Lines 16050 16055 +5
==========================================
Hits 11375 11375
- Misses 3844 3846 +2
- Partials 831 834 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this @dat-boris ! Have a few tiny nit comments :)
Co-authored-by: Brian de Alwis <bsd@acm.org>
Sorry @dat-boris for the delay — I held off as I wanted to check how we were using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @dat-boris for the contribution :)
Thank you @briandealwis @MarlonGamez for the reviews! Yeah it make sense to revert to the old |
Fixes: #5713
Related: #5590
Merge before/after: None
Description
In #5713 we discover that the new port detection logic does not apply
to GRPC startup, which default starts on Mac on IPv4 loopback.
Test plan:
Locally run multiple version of skaffold, ensure that none
of them have issues with starting up their own RPC server.
Instead of crashing, it now correctly skip previous ports used by RPC