-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to empty secret path for Kaniko to use Workload Identity credentials #5730
Default to empty secret path for Kaniko to use Workload Identity credentials #5730
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
d243bdc
to
390948c
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
390948c
to
d29c19f
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
d29c19f
to
dd2dc87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase!
…entials Signed-off-by: Vladimir Ivanov <vladimir.ivanov@grasshopperasia.com>
dd2dc87
to
cbcc43c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5730 +/- ##
=======================================
Coverage 70.95% 70.95%
=======================================
Files 439 439
Lines 16408 16410 +2
=======================================
+ Hits 11642 11644 +2
Misses 3913 3913
Partials 853 853
Continue to review full report at Codecov.
|
Fixes: #3468
Description
If
GOOGLE_APPLICATION_CREDENTIALS
is set, Kaniko doesn't opt for using Workload Identity. Current setup always forces non-emptyGOOGLE_APPLICATION_CREDENTIALS
value. Proposed change make empty value default forpullSecretPath
, unless MountPath is specified in the config. This in turn preventsGOOGLE_APPLICATION_CREDENTIALS
from being set.