-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _index.md #5752
Update _index.md #5752
Conversation
I know. Nobody expects the Spanish Inquisition. Amongst our stages are ...
Codecov Report
@@ Coverage Diff @@
## master #5752 +/- ##
==========================================
- Coverage 70.87% 70.74% -0.13%
==========================================
Files 421 433 +12
Lines 16087 16256 +169
==========================================
+ Hits 11401 11501 +100
- Misses 3850 3908 +58
- Partials 836 847 +11
Continue to review full report at Codecov.
|
Ha! Thanks for noticing. Definitely needs @nkubala's input because I'm not sure if we're counting the blue squares or all squares. |
Please visit http://35.236.94.72:1313 to view changes to the docs. |
@briandealwis In addition to the initial diagram, which has 7+2 stages, there is also the table of Skaffold Pipeline stages at the bottom of the page, which has nine rows - but maybe By the way, elsewhere (api.md), the doc refers to the phases of the pipeline as build, deploy, and sync. |
@joebowbeer lol nice catch :) to be honest our diagrams are getting stale and might need to be updated in the future. I wonder if we should just say |
also worth mentioning that as a team we collectively agree our docs need lots of love - this is yet another item to add to the list of things to address |
s/nine/multi/
@nkubala I applied your multi-stage suggestion. |
Description
Do not specify the exact number of skaffold stages. The currently specified number does not agree with the diagram or subsequent table, and is likely to change.
I know. Nobody expects the Spanish Inquisition.
Amongst our stages are ...