Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move kubernetes log code to pkg/skaffold/kubernetes/logger #5761

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Apr 29, 2021

this change moves the logging related code in the kubernetes package to its own logger package. this will make it easier to reuse later when we embed the logging functionality inside the deployer.

also, move some unrelated image tracking logic out from the logging code.

this change is non-functional.

@nkubala nkubala requested a review from a team as a code owner April 29, 2021 22:21
@nkubala nkubala requested a review from gsquared94 April 29, 2021 22:21
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@nkubala nkubala enabled auto-merge (squash) April 29, 2021 22:22
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #5761 (7362055) into master (21e3c95) will decrease coverage by 0.24%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5761      +/-   ##
==========================================
- Coverage   70.89%   70.65%   -0.25%     
==========================================
  Files         421      428       +7     
  Lines       16091    16174      +83     
==========================================
+ Hits        11408    11428      +20     
- Misses       3849     3906      +57     
- Partials      834      840       +6     
Impacted Files Coverage Δ
pkg/skaffold/runner/dev.go 71.82% <ø> (ø)
pkg/skaffold/runner/logger.go 40.00% <0.00%> (ø)
pkg/skaffold/schema/latest/v1/config.go 58.82% <ø> (ø)
pkg/skaffold/schema/v2beta14/upgrade.go 100.00% <ø> (ø)
pkg/skaffold/schema/versions.go 82.41% <ø> (ø)
pkg/skaffold/schema/v2beta15/config.go 20.58% <20.58%> (ø)
pkg/skaffold/kubernetes/image_list.go 100.00% <100.00%> (ø)
pkg/skaffold/kubernetes/logger/log.go 42.45% <100.00%> (ø)
pkg/skaffold/schema/v2beta15/upgrade.go 100.00% <100.00%> (ø)
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 789d058...7362055. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to change the license header year to 2021 for pkg/skaffold/kubernetes/logger/log.go? Not sure how simply moving a file works with that

@nkubala
Copy link
Contributor Author

nkubala commented Apr 30, 2021

Do we have to change the license header year to 2021 for pkg/skaffold/kubernetes/logger/log.go? Not sure how simply moving a file works with that

the convention we follow is to only change the year in the license header for new files, otherwise we'd have to constantly update them and we'd forget all the time.

@nkubala nkubala merged commit eb19481 into GoogleContainerTools:master Apr 30, 2021
@nkubala nkubala deleted the k8s-logger branch April 30, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants