Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] (part 1) Change runner/v3 to runner/v2. Update v3 flag to v2 #5780

Merged
merged 1 commit into from
May 5, 2021
Merged

[V3] (part 1) Change runner/v3 to runner/v2. Update v3 flag to v2 #5780

merged 1 commit into from
May 5, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented May 4, 2021 •
edited
Loading

Related: #5727
Merge before: #5781

@yuwenma yuwenma requested a review from a team as a code owner May 4, 2021 08:59
@yuwenma yuwenma requested a review from tejal29 May 4, 2021 08:59
@google-cla google-cla bot added the cla: yes label May 4, 2021
@yuwenma yuwenma mentioned this pull request May 4, 2021
Merged
@codecov
Copy link

codecov bot commented May 4, 2021 •
edited
Loading

Codecov Report

Merging #5780 (c2f08e8) into master (b1fa526) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5780   +/-   ##
=======================================
  Coverage   70.79%   70.79%           
=======================================
  Files         436      436           
  Lines       16356    16356           
=======================================
  Hits        11579    11579           
  Misses       3923     3923           
  Partials      854      854
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.02% <ø> (ø)
pkg/skaffold/runner/v2/apply.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/v2/cleanup.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/v2/deploy.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/v2/dev.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/v2/generate_pipeline.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/v2/render.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/v2/runner.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fa526...c2f08e8. Read the comment docs.

@yuwenma yuwenma force-pushed the runner-1-v3-flag branch from 576dbed to be5aeb1 Compare May 4, 2021 11:55
@yuwenma yuwenma added this to the v1.24.0 milestone May 4, 2021
@yuwenma yuwenma added the area/v3 V3 label May 4, 2021
@yuwenma yuwenma force-pushed the runner-1-v3-flag branch from be5aeb1 to c2f08e8 Compare May 5, 2021 20:12
MarlonGamez
MarlonGamez approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I can merge once CI is green 👍🏼

@yuwenma
Copy link
Contributor Author

yuwenma commented May 5, 2021 •
edited
Loading

lgtm, I can merge once CI is green 👍🏼

🙇 🙇 🙇 🙇 Sweet! Thank you so much! @MarlonGamez

@MarlonGamez MarlonGamez merged commit 347606e into GoogleContainerTools:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarlonGamez MarlonGamez MarlonGamez approved these changes

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
area/v3 V3 cla: yes size/M
Projects
None yet
Milestone
v1.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yuwenma @MarlonGamez