Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting default deployer definition #5861

Merged
merged 1 commit into from
May 19, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes: #5818

@gsquared94 gsquared94 requested a review from tejal29 May 18, 2021 21:56
@gsquared94 gsquared94 requested a review from a team as a code owner May 18, 2021 21:56
@google-cla google-cla bot added the cla: yes label May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #5861 (fc0e9d4) into master (c44d98a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5861      +/-   ##
==========================================
- Coverage   70.81%   70.80%   -0.02%     
==========================================
  Files         446      446              
  Lines       16816    16816              
==========================================
- Hits        11909    11907       -2     
- Misses       4023     4024       +1     
- Partials      884      885       +1     
Impacted Files Coverage Δ
pkg/skaffold/schema/defaults/defaults.go 86.66% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44d98a...fc0e9d4. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsquared94 gsquared94 merged commit 7a2ba77 into GoogleContainerTools:master May 19, 2021
@tejal29 tejal29 added this to the v1.25.0 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious warning when using only remote manifests
3 participants