Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml reference rendering for object-type examples #5872

Merged
merged 1 commit into from
May 20, 2021

Conversation

briandealwis
Copy link
Member

Fixes: #5841

Description
Our JS rendering of the skaffold.yaml schemas was swallowing the key-part when walking the key-value pairs in an object-style example. The only examples of this type are the buildArgs fields of our builders.

Before
Screen Shot 2021-05-20 at 10 05 30 AM

After
Screen Shot 2021-05-20 at 10 05 44 AM

@briandealwis briandealwis added docs-modifications runs the docs preview service on the given PR area/yaml-docs labels May 20, 2021
@briandealwis briandealwis requested a review from a team as a code owner May 20, 2021 14:08
@briandealwis briandealwis requested a review from gsquared94 May 20, 2021 14:08
@google-cla google-cla bot added the cla: yes label May 20, 2021
@container-tools-bot
Copy link

Please visit http://34.102.7.152:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label May 20, 2021
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

2 similar comments
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #5872 (4322d29) into master (6c57b21) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5872   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files         446      446           
  Lines       16855    16855           
=======================================
+ Hits        11949    11950    +1     
  Misses       4021     4021           
+ Partials      885      884    -1     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️
pkg/skaffold/docker/image.go 79.72% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c57b21...4322d29. Read the comment docs.

@tejal29 tejal29 requested review from MarlonGamez and removed request for gsquared94 May 20, 2021 18:49
@MarlonGamez MarlonGamez added the docs-modifications runs the docs preview service on the given PR label May 20, 2021
@container-tools-bot
Copy link

Please visit http://34.102.7.152:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label May 20, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Lgtm 👍🏼

@MarlonGamez MarlonGamez merged commit ff5038a into GoogleContainerTools:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs need an example of how to use .build.docker.buildArgs
3 participants