-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yaml reference rendering for object-type examples #5872
Conversation
Please visit http://34.102.7.152:1313 to view changes to the docs. |
Error creating deployment, please see controller logs for details. |
2 similar comments
Error creating deployment, please see controller logs for details. |
Error creating deployment, please see controller logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #5872 +/- ##
=======================================
Coverage 70.89% 70.89%
=======================================
Files 446 446
Lines 16855 16855
=======================================
+ Hits 11949 11950 +1
Misses 4021 4021
+ Partials 885 884 -1
Continue to review full report at Codecov.
|
Please visit http://34.102.7.152:1313 to view changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Lgtm 👍🏼
Fixes: #5841
Description
Our JS rendering of the
skaffold.yaml
schemas was swallowing the key-part when walking the key-value pairs in an object-style example. The only examples of this type are thebuildArgs
fields of our builders.Before
After