Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-containerregistry to 0.5.1 #5881

Merged
merged 1 commit into from
May 21, 2021

Conversation

briandealwis
Copy link
Member

Description
Update go-containerregistry to 0.5.1 to pull in the fix from google/go-containerregistry#1017.

This should address a report from @russwolf where Skaffold failed during a file-sync with a Buildpacks image, where the image was a remote image built using GCB:

files modified: [src/index.html.hbs]
error adding dirty artifact to changeset: retrieving labels for \"gcr.io/next-london-cloudcode/nodejs-hello-world:latest@sha256:7f72c0ed595081552a94d4c4400d89be0c49844dfd3a138b849651aafb220b35\": retrieving image config: error executing `gcloud config config-helper`: exec: already started

@briandealwis briandealwis requested a review from a team as a code owner May 21, 2021 03:03
@briandealwis briandealwis requested a review from MarlonGamez May 21, 2021 03:03
@google-cla google-cla bot added the cla: yes label May 21, 2021
@briandealwis briandealwis mentioned this pull request May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #5881 (3022c38) into master (ff5038a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5881   +/-   ##
=======================================
  Coverage   70.91%   70.91%           
=======================================
  Files         447      447           
  Lines       16908    16908           
=======================================
  Hits        11990    11990           
  Misses       4028     4028           
  Partials      890      890           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5038a...3022c38. Read the comment docs.

@briandealwis briandealwis merged commit 2bf3981 into GoogleContainerTools:master May 21, 2021
@briandealwis briandealwis deleted the ggcr-0.5.1 branch May 21, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants