Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Structure Test page should use skaffold test #5911

Merged

Conversation

briandealwis
Copy link
Member

@briandealwis briandealwis commented May 26, 2021

Merge after: #5912

Description

@tete17 pointed out that the Container Structure Test page uses skaffold build to run tests:

Screen Shot 2021-05-26 at 3 48 05 PM

@briandealwis briandealwis requested a review from a team as a code owner May 26, 2021 19:50
@google-cla google-cla bot added the cla: yes label May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #5911 (02834ed) into master (c788c2b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5911      +/-   ##
==========================================
+ Coverage   70.88%   70.89%   +0.01%     
==========================================
  Files         448      448              
  Lines       16955    16955              
==========================================
+ Hits        12018    12021       +3     
+ Misses       4038     4037       -1     
+ Partials      899      897       -2     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 79.72% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c788c2b...02834ed. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarlonGamez MarlonGamez merged commit 67a6c6a into GoogleContainerTools:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants