Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix remoteChart tests #5921

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

briandealwis
Copy link
Member

Related: #5887

Description
In fixing #5887, I realized we don't have tests for deploy with remoteCharts. The existing deploy test for a remote-chart is a vestige of the original skipBuildDependencies being used for remote charts, and doesn't actually seem to be a remote chart. I think?

@briandealwis briandealwis requested a review from nkubala May 30, 2021 03:22
@briandealwis briandealwis requested a review from a team as a code owner May 30, 2021 03:22
@google-cla google-cla bot added the cla: yes label May 30, 2021
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #5921 (843f4e2) into master (0549530) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5921      +/-   ##
==========================================
+ Coverage   70.90%   70.92%   +0.01%     
==========================================
  Files         448      448              
  Lines       16968    16968              
==========================================
+ Hits        12032    12035       +3     
+ Misses       4038     4036       -2     
+ Partials      898      897       -1     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.34% <0.00%> (-1.39%) ⬇️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/server/server.go 41.96% <0.00%> (ø)
pkg/skaffold/deploy/helm/deploy.go 77.52% <0.00%> (+0.91%) ⬆️
pkg/skaffold/deploy/helm/args.go 81.13% <0.00%> (+1.88%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0549530...843f4e2. Read the comment docs.

@tejal29 tejal29 merged commit e8803ad into GoogleContainerTools:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants