-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add command skaffold inspect build-env modify googleCloudBuild
#5935
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5935 +/- ##
==========================================
+ Coverage 70.57% 70.66% +0.09%
==========================================
Files 457 458 +1
Lines 17534 17609 +75
==========================================
+ Hits 12374 12443 +69
- Misses 4246 4251 +5
- Partials 914 915 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel, just having this command is not sufficient.
We also need to provide a way for IDEs to detect if googleCloudBuild profile exists.
$skaffold inspect build-env list googleCloudBuild
gcb-dev
gcb-prod
gcb-staging
$skaffold inspect build-env modify googleCloudBuild -p gcb.
However, we can do this in another PR
We have that in:
|
Related: #5758
Description
add command
skaffold inspect build-env modify googleCloudBuild
to modify the build environment definitions of profiles and default pipelines.User facing changes (remove if N/A)