Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinct error codes for docker no space error and better suggestion #5938

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Jun 4, 2021

Fixes #5862

Add a distinct error code for docker system error and following suggestions

  1. Rundocker system prune to clean docker data and
  2. Run skaffold dev/debug with --cleanup=true flag if its set to false to prune intermediate images

Other Changes

  1. Add docker.Config to Docker Builder instead of 3 separate fields for prune, insecureRegistries and runMode.
    This docker.Config will now get passed to newBuildError

@tejal29 tejal29 requested a review from a team as a code owner June 4, 2021 02:16
@tejal29 tejal29 requested a review from briandealwis June 4, 2021 02:16
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #5938 (dffd7d0) into master (aa9b115) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5938      +/-   ##
==========================================
+ Coverage   70.66%   70.70%   +0.03%     
==========================================
  Files         454      454              
  Lines       17399    17408       +9     
==========================================
+ Hits        12295    12308      +13     
+ Misses       4196     4193       -3     
+ Partials      908      907       -1     
Impacted Files Coverage Δ
pkg/skaffold/build/docker/errors.go 63.95% <70.58%> (+7.95%) ⬆️
pkg/skaffold/build/docker/docker.go 88.46% <100.00%> (+3.84%) ⬆️
pkg/skaffold/build/docker/types.go 100.00% <100.00%> (ø)
pkg/skaffold/build/local/types.go 86.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b115...dffd7d0. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@tejal29 tejal29 merged commit 1675c84 into GoogleContainerTools:master Jun 4, 2021
@tejal29 tejal29 deleted the add_no_space branch July 21, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better actionable error when docker is out of memory instead of BUILD_DOCKER_SYSTEM_ERR
3 participants