Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure SkaffoldLogEvent types go through correct endpoint #5964

Merged

Conversation

MarlonGamez
Copy link
Contributor

Related: #5368 #5370

Description
Ensures that SkaffoldLogEvents are sent through the proper endpoint.

@MarlonGamez MarlonGamez requested a review from a team as a code owner June 7, 2021 21:52
@MarlonGamez MarlonGamez requested a review from nkubala June 7, 2021 21:52
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shd they be available at /skaffoldLogs endpoint now?

@tejal29 tejal29 enabled auto-merge (squash) June 7, 2021 23:27
@tejal29 tejal29 disabled auto-merge June 7, 2021 23:27
@MarlonGamez
Copy link
Contributor Author

@tejal29 I'm still not sending anything just yet, just setting up so that my next PR which does send them out will send them on that endpoint

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #5964 (23fcba0) into master (20e00dc) will increase coverage by 0.11%.
The diff coverage is 77.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5964      +/-   ##
==========================================
+ Coverage   70.57%   70.68%   +0.11%     
==========================================
  Files         457      459       +2     
  Lines       17534    17601      +67     
==========================================
+ Hits        12374    12441      +67     
+ Misses       4246     4239       -7     
- Partials      914      921       +7     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/inspect_modules.go 87.50% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 92.30% <0.00%> (ø)
pkg/skaffold/inspect/types.go 100.00% <ø> (ø)
pkg/skaffold/deploy/kpt/kpt.go 82.04% <68.08%> (+4.78%) ⬆️
cmd/skaffold/app/cmd/inspect_build_env.go 59.44% <76.92%> (+3.60%) ⬆️
pkg/skaffold/inspect/buildEnv/modify_gcb.go 81.25% <81.25%> (ø)
pkg/skaffold/inspect/errors.go 56.09% <85.18%> (+56.09%) ⬆️
pkg/skaffold/deploy/status/status_check.go 69.40% <85.71%> (-0.30%) ⬇️
cmd/skaffold/app/cmd/inspect.go 100.00% <100.00%> (ø)
pkg/skaffold/build/util.go 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0e186...23fcba0. Read the comment docs.

@MarlonGamez MarlonGamez merged commit a9e026e into GoogleContainerTools:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants