-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use event writer in skaffold execution #5965
Merged
tejal29
merged 6 commits into
GoogleContainerTools:master
from
MarlonGamez:build-output-events
Jun 16, 2021
Merged
use event writer in skaffold execution #5965
tejal29
merged 6 commits into
GoogleContainerTools:master
from
MarlonGamez:build-output-events
Jun 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5965 +/- ##
==========================================
- Coverage 70.79% 70.78% -0.02%
==========================================
Files 462 462
Lines 17866 17897 +31
==========================================
+ Hits 12649 12668 +19
- Misses 4286 4298 +12
Partials 931 931
Continue to review full report at Codecov.
|
MarlonGamez
changed the title
[WIP] use event writer in skaffold execution
use event writer in skaffold execution
Jun 14, 2021
tejal29
reviewed
Jun 16, 2021
tejal29
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5370
Description
Sets up the main
skaffoldWriter
to also use an event writer so that output gets written on the/skaffoldLogs
API endpoint as well. Also sets up some event writer contexts for build and deploy phases so that the output events can be categorized.User facing changes (remove if N/A)
users can now hit the
/skaffoldLogs
endpoint to see output from skaffold being emitted as events.Follow-up Work (remove if N/A)
Set up more calls to
WithEventContext
so that things are further organized.