Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use event writer in skaffold execution #5965

Merged
merged 6 commits into from
Jun 16, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Jun 7, 2021

Related: #5370

Description
Sets up the main skaffoldWriter to also use an event writer so that output gets written on the /skaffoldLogs API endpoint as well. Also sets up some event writer contexts for build and deploy phases so that the output events can be categorized.

User facing changes (remove if N/A)
users can now hit the /skaffoldLogs endpoint to see output from skaffold being emitted as events.

Follow-up Work (remove if N/A)
Set up more calls to WithEventContext so that things are further organized.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #5965 (d43feb0) into master (7f754f6) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5965      +/-   ##
==========================================
- Coverage   70.79%   70.78%   -0.02%     
==========================================
  Files         462      462              
  Lines       17866    17897      +31     
==========================================
+ Hits        12649    12668      +19     
- Misses       4286     4298      +12     
  Partials      931      931              
Impacted Files Coverage Δ
pkg/skaffold/build/result.go 83.33% <0.00%> (ø)
pkg/skaffold/event/v2/event.go 79.83% <ø> (ø)
pkg/skaffold/event/v2/build.go 92.30% <33.33%> (-7.70%) ⬇️
pkg/skaffold/build/scheduler.go 92.18% <100.00%> (+0.12%) ⬆️
pkg/skaffold/deploy/deploy_mux.go 76.31% <100.00%> (+0.64%) ⬆️
pkg/skaffold/output/output.go 80.64% <100.00%> (ø)
pkg/skaffold/runner/build_deploy.go 73.11% <100.00%> (+0.29%) ⬆️
pkg/skaffold/runner/v1/deploy.go 53.46% <100.00%> (+0.46%) ⬆️
pkg/diag/validator/pod.go 1.11% <0.00%> (-0.12%) ⬇️
pkg/skaffold/deploy/status/status_check.go 70.92% <0.00%> (+0.84%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f754f6...d43feb0. Read the comment docs.

@MarlonGamez MarlonGamez marked this pull request as ready for review June 14, 2021 21:00
@MarlonGamez MarlonGamez requested a review from a team as a code owner June 14, 2021 21:00
@MarlonGamez MarlonGamez requested a review from tejal29 June 14, 2021 21:00
@MarlonGamez MarlonGamez changed the title [WIP] use event writer in skaffold execution use event writer in skaffold execution Jun 14, 2021
@tejal29 tejal29 merged commit 5c2e24c into GoogleContainerTools:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants