Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove podSelector from Runner #6076

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Jun 24, 2021

Now that all podSelector-dependent components have been moved inside the Deployer, the podSelector serves no purpose inside the Runner.

@nkubala nkubala requested review from yuwenma and a team as code owners June 24, 2021 22:22
@nkubala nkubala requested a review from tejal29 June 24, 2021 22:22
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #6076 (74b8493) into master (f08c6d6) will increase coverage by 0.01%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6076      +/-   ##
==========================================
+ Coverage   70.19%   70.21%   +0.01%     
==========================================
  Files         475      475              
  Lines       18147    18142       -5     
==========================================
  Hits        12739    12739              
+ Misses       4471     4469       -2     
+ Partials      937      934       -3     
Impacted Files Coverage Δ
pkg/skaffold/deploy/kpt/kpt.go 80.85% <ø> (-0.07%) ⬇️
pkg/skaffold/runner/v1/runner.go 0.00% <ø> (ø)
pkg/skaffold/deploy/kubectl/kubectl.go 68.31% <50.00%> (ø)
pkg/skaffold/deploy/kustomize/kustomize.go 74.34% <50.00%> (ø)
pkg/skaffold/runner/deployer.go 59.03% <56.25%> (-2.33%) ⬇️
pkg/skaffold/deploy/helm/deploy.go 78.22% <100.00%> (ø)
pkg/skaffold/runner/v1/new.go 64.16% <100.00%> (-0.59%) ⬇️
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/event/v2/status_check.go 100.00% <0.00%> (ø)
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08c6d6...74b8493. Read the comment docs.

@tejal29 tejal29 self-assigned this Jun 25, 2021
@gsquared94 gsquared94 enabled auto-merge (squash) June 28, 2021 10:26
@gsquared94 gsquared94 merged commit b8124d0 into GoogleContainerTools:master Jun 28, 2021
@nkubala nkubala deleted the remove-podselector branch June 28, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants