GCB project guessing should support Artifact Registry images #6093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
approved these changes
Jun 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #6093 +/- ##
=======================================
Coverage 70.20% 70.20%
=======================================
Files 475 475
Lines 18142 18142
=======================================
Hits 12736 12736
Misses 4470 4470
Partials 936 936
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6092
Related: #5053
Description
GCB has support for guessing GCP Project IDs from a GCR image reference (gcr.io). We need similar support for Artifact Registry.