Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize k8s-skaffold/skaffold image #6106

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

briandealwis
Copy link
Member

Rework the gcr.io/k8s-skaffold/skaffold image building process to avoid leaving build artifacts in the image.

@briandealwis briandealwis requested a review from tejal29 June 29, 2021 16:43
@briandealwis briandealwis requested a review from a team as a code owner June 29, 2021 16:43
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #6106 (f379e6d) into master (044c65f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6106      +/-   ##
==========================================
- Coverage   70.19%   70.18%   -0.02%     
==========================================
  Files         475      475              
  Lines       18156    18187      +31     
==========================================
+ Hits        12745    12764      +19     
- Misses       4475     4482       +7     
- Partials      936      941       +5     
Impacted Files Coverage Δ
pkg/skaffold/schema/validation/validation.go 84.44% <0.00%> (-2.62%) ⬇️
pkg/skaffold/server/server.go 41.96% <0.00%> (ø)
pkg/skaffold/schema/latest/v1/config.go 58.82% <0.00%> (ø)
pkg/skaffold/build/cluster/pod.go 86.95% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044c65f...f379e6d. Read the comment docs.

@tejal29 tejal29 enabled auto-merge (squash) June 29, 2021 18:56
@tejal29 tejal29 merged commit 58a4652 into GoogleContainerTools:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants