Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change proto v1 package name #6112

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Jun 29, 2021

related: #5986

Description
Renames the GoogleContainerTools/skaffold/proto/v1/ package name from proto to v1, by adding an option go_package statement in the proto file. This change needs to be made for future updates to our proto generation toolchain. It also makes package naming more understandable.

Most of the changes here are generated files or changing import statements.

@MarlonGamez MarlonGamez requested a review from a team as a code owner June 29, 2021 23:26
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #6112 (50ac645) into master (1f46f24) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6112   +/-   ##
=======================================
  Coverage   70.15%   70.15%           
=======================================
  Files         475      475           
  Lines       18191    18191           
=======================================
  Hits        12761    12761           
  Misses       4487     4487           
  Partials      943      943           
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/runner.go 57.14% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <ø> (ø)
pkg/diag/validator/pod.go 1.09% <ø> (ø)
pkg/diag/validator/resource.go 50.00% <ø> (ø)
pkg/skaffold/build/build_problems.go 93.44% <ø> (ø)
pkg/skaffold/build/docker/errors.go 63.95% <ø> (ø)
pkg/skaffold/build/jib/errors.go 48.83% <ø> (ø)
pkg/skaffold/deploy/deploy_problems.go 80.00% <ø> (ø)
pkg/skaffold/deploy/error/errors.go 50.00% <ø> (ø)
pkg/skaffold/deploy/helm/errors.go 89.79% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f46f24...50ac645. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarlonGamez MarlonGamez added the docs-modifications runs the docs preview service on the given PR label Jun 30, 2021
@container-tools-bot
Copy link

Please visit http://34.94.219.215:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jun 30, 2021
@MarlonGamez MarlonGamez merged commit 83168c8 into GoogleContainerTools:master Jun 30, 2021
MarlonGamez added a commit that referenced this pull request Jul 2, 2021
MarlonGamez added a commit that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants