-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change proto v1 package name #6112
Change proto v1 package name #6112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6112 +/- ##
=======================================
Coverage 70.15% 70.15%
=======================================
Files 475 475
Lines 18191 18191
=======================================
Hits 12761 12761
Misses 4487 4487
Partials 943 943
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please visit http://34.94.219.215:1313 to view changes to the docs. |
This reverts commit 83168c8.
related: #5986
Description
Renames the
GoogleContainerTools/skaffold/proto/v1/
package name fromproto
tov1
, by adding anoption go_package
statement in the proto file. This change needs to be made for future updates to our proto generation toolchain. It also makes package naming more understandable.Most of the changes here are generated files or changing import statements.