Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move log stream utility out of pkg/skaffold/kubernetes #6121

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Jul 1, 2021

Related: #6107

This moves the StreamRequest method out of pkg/skaffold/kubernetes so it can be used by other Logger implementations.

@nkubala nkubala requested a review from a team as a code owner July 1, 2021 17:34
@nkubala nkubala requested a review from gsquared94 July 1, 2021 17:34
@google-cla google-cla bot added the cla: yes label Jul 1, 2021
@nkubala nkubala enabled auto-merge (squash) July 1, 2021 17:41
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #6121 (4d16ad3) into master (fe12a8a) will decrease coverage by 0.00%.
The diff coverage is 22.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6121      +/-   ##
==========================================
- Coverage   69.96%   69.96%   -0.01%     
==========================================
  Files         477      478       +1     
  Lines       18283    18286       +3     
==========================================
+ Hits        12792    12794       +2     
- Misses       4545     4547       +2     
+ Partials      946      945       -1     
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/logger/log.go 38.29% <0.00%> (+1.69%) ⬆️
pkg/skaffold/log/stream/stream.go 23.80% <23.80%> (ø)
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe12a8a...4d16ad3. Read the comment docs.

@nkubala nkubala merged commit 5bc26fb into GoogleContainerTools:master Jul 1, 2021
@nkubala nkubala deleted the log-stream branch July 1, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants