Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContainerTracker for tracking deployed docker containers #6266

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Jul 21, 2021

Related: #6107

Description

This change adds a ContainerTracker object, which tracks all containers deployed to the local Docker daemon by Skaffold. This object's purpose is analogous to the PodSelector, which is used for all Kubernetes-based Deployer sub-components.

The ContainerTracker will be passed to all future implementations of these sub-components in the Docker deployer, and will inform those components which resources to retrieve and operate on. It will also help the ColorPicker select the proper colors for individual container logs (when implemented).

Follow-up Work (remove if N/A)

Use ContainerTracker to implement Deployer sub-components for the Docker deployer.

@nkubala nkubala requested a review from a team as a code owner July 21, 2021 20:48
@nkubala nkubala requested a review from briandealwis July 21, 2021 20:48
@google-cla google-cla bot added the cla: yes label Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #6266 (d88392c) into main (7453095) will increase coverage by 0.00%.
The diff coverage is 43.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6266   +/-   ##
=======================================
  Coverage   70.84%   70.85%           
=======================================
  Files         490      491    +1     
  Lines       22123    22208   +85     
=======================================
+ Hits        15673    15735   +62     
- Misses       5434     5457   +23     
  Partials     1016     1016           
Impacted Files Coverage Δ
pkg/skaffold/deploy/docker/deploy.go 0.00% <0.00%> (ø)
pkg/skaffold/docker/tracker/tracker.go 85.29% <85.29%> (ø)
pkg/skaffold/event/v2/logger.go 88.23% <0.00%> (-11.77%) ⬇️
...g/skaffold/kubernetes/portforward/entry_manager.go 91.78% <0.00%> (+0.11%) ⬆️
cmd/skaffold/app/cmd/cmd.go 73.65% <0.00%> (+0.14%) ⬆️
pkg/skaffold/runner/build.go 74.28% <0.00%> (+0.24%) ⬆️
pkg/skaffold/build/cache/retrieve.go 64.40% <0.00%> (+0.30%) ⬆️
pkg/skaffold/kubernetes/status/status_check.go 52.40% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7453095...d88392c. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a couple nits but lgtm

pkg/skaffold/docker/tracker/tracker.go Outdated Show resolved Hide resolved
pkg/skaffold/docker/tracker/tracker.go Outdated Show resolved Hide resolved
@nkubala nkubala enabled auto-merge (squash) July 22, 2021 18:22
@nkubala
Copy link
Contributor Author

nkubala commented Jul 22, 2021

CI is failing because of #6262. self merging

@nkubala nkubala disabled auto-merge July 22, 2021 20:50
@nkubala nkubala merged commit 9d1f035 into GoogleContainerTools:main Jul 22, 2021
@nkubala nkubala deleted the container-tracker branch July 22, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants