Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to generate override values.yaml based on data passed into skaffold.yaml #632

Merged
merged 10 commits into from
Jun 7, 2018

Conversation

louis-murray
Copy link

This is the implementation for #585.

When looking at the code more I saw the reason that values only contains images so I made a new field called overrides that will contain the contents of the generated override values.yaml.

I think the best course of action to clear up any confusion would be to rename the values section to something more image related like artifacts and then the overrides section I've implemented here would become values. I'd be happy to include that change in this PR but didn't want to introduce a breaking change without speaking about it first. Otherwise, it's just something to keep note of for the next major version bump

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@louis-murray
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dgageot
Copy link
Contributor

dgageot commented Jun 5, 2018

@louis-murray Can you please rebase?

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@louis-murray
Copy link
Author

@dgageot done!

@googlebot
Copy link

CLAs look good, thanks!

@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Jun 6, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 6, 2018
Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@r2d4 r2d4 merged commit aa944bc into GoogleContainerTools:master Jun 7, 2018
@louis-murray louis-murray deleted the overrides branch June 7, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants