Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to toggle the --wait flag on helm install/upgrade #633

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Add functionality to toggle the --wait flag on helm install/upgrade #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6a46e2
added wait field to schema
Jun 5, 2018
b4802bb
added code to handle adding --wait to helm command
Jun 5, 2018
b4f4c69
updated example to have wait flag
Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/helm-deployment/skaffold.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ deploy:
- name: skaffold-helm
chartPath: skaffold-helm
namespace: skaffold
#wait: true
#valuesFilePath: helm-skaffold-values.yaml
values:
image: skaffold-helm
Expand Down
3 changes: 3 additions & 0 deletions pkg/skaffold/deploy/helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ func (h *HelmDeployer) deployRelease(out io.Writer, r v1alpha2.HelmRelease, buil
setOpts = append(setOpts, fmt.Sprintf("%s=%s", k, v))
}
}
if r.Wait {
args = append(args, "--wait")
}
args = append(args, setOpts...)

return h.helm(out, args...)
Expand Down
1 change: 1 addition & 0 deletions pkg/skaffold/schema/v1alpha2/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ type HelmRelease struct {
Namespace string `yaml:"namespace"`
Version string `yaml:"version"`
SetValues map[string]string `yaml:"setValues"`
Wait bool `yaml:"wait"`
}

// Artifact represents items that need to be built, along with the context in which
Expand Down