Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with displaying survey prompts when we shouldn't #6354

Merged

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Aug 3, 2021

Fixes: #6353

Description
Currently in PersistentPostRun, we do if isQuietMode() && !isHouseKeepingMessagesAllowed(cmd), but it should be if isQuietMode() || !isHouseKeepingMessagesAllowed(cmd). This change will fix users seeing housekeeping messages when they shouldn't.

@MarlonGamez MarlonGamez requested a review from a team as a code owner August 3, 2021 21:06
@MarlonGamez MarlonGamez requested a review from nkubala August 3, 2021 21:06
@google-cla google-cla bot added the cla: yes label Aug 3, 2021
@MarlonGamez MarlonGamez changed the title Fix && to || in PersistentPostRun Fix issue with displaying survey prompts when we shouldn't Aug 3, 2021
@MarlonGamez MarlonGamez enabled auto-merge (squash) August 3, 2021 21:21
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #6354 (40764aa) into main (2d36770) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6354      +/-   ##
==========================================
- Coverage   70.50%   70.47%   -0.04%     
==========================================
  Files         498      498              
  Lines       22581    22581              
==========================================
- Hits        15920    15913       -7     
- Misses       5630     5638       +8     
+ Partials     1031     1030       -1     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 71.50% <100.00%> (-2.16%) ⬇️
pkg/skaffold/log/stream/stream.go 64.28% <0.00%> (-21.43%) ⬇️
pkg/skaffold/util/tar.go 63.21% <0.00%> (-2.30%) ⬇️
pkg/skaffold/docker/parse.go 88.23% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d36770...40764aa. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 1e3da21 into GoogleContainerTools:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure skaffold doesn't prompt for surveys when deploying in non-interactive mode
2 participants