Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rename section "Working with Skaffold" to "Guides" #6537

Merged
merged 1 commit into from
Aug 30, 2021
Merged

docs: rename section "Working with Skaffold" to "Guides" #6537

merged 1 commit into from
Aug 30, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes: #6490
image

@gsquared94 gsquared94 requested a review from nkubala August 30, 2021 05:17
@gsquared94 gsquared94 requested a review from a team as a code owner August 30, 2021 05:17
@google-cla google-cla bot added the cla: yes label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021 •
edited
Loading

Codecov Report

Merging #6537 (5b44593) into main (cfe7882) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6537   +/-   ##
=======================================
  Coverage   70.44%   70.44%           
=======================================
  Files         515      515           
  Lines       23144    23144           
=======================================
  Hits        16303    16303           
+ Misses       5785     5783    -2     
- Partials     1056     1058    +2
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 65.56% <0.00%> (-1.00%) ⬇️
pkg/skaffold/log/stream/stream.go 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe7882...5b44593. Read the comment docs.

@gsquared94 gsquared94 changed the title rename section "Working with Skaffold" to "Guides" docs: rename section "Working with Skaffold" to "Guides" Aug 30, 2021
MarlonGamez
MarlonGamez approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording is simpler and more immediately clear. LGTM 👍🏼

@MarlonGamez MarlonGamez merged commit 5b42546 into GoogleContainerTools:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarlonGamez MarlonGamez MarlonGamez approved these changes

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs fixit] [technical writers review] Rename Working With Skaffold to Guides
2 participants
@gsquared94 @MarlonGamez