Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist EventV2 logs when --event-log-file exists #6581

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Persist EventV2 logs when --event-log-file exists #6581

merged 1 commit into from
Sep 10, 2021

Conversation

verbanicm
Copy link
Contributor

Fixes: #6533

Description
Added code to persist EventV2 logs in a separate log file with extension .v2 if the --event-log-file flag is set

@verbanicm verbanicm requested a review from a team as a code owner September 9, 2021 16:43
@google-cla google-cla bot added the cla: yes label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #6581 (e544d0a) into main (290280e) will decrease coverage by 0.07%.
The diff coverage is 51.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6581      +/-   ##
==========================================
- Coverage   70.48%   70.40%   -0.08%     
==========================================
  Files         515      517       +2     
  Lines       23150    23272     +122     
==========================================
+ Hits        16317    16385      +68     
- Misses       5776     5826      +50     
- Partials     1057     1061       +4     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 70.68% <0.00%> (-0.38%) ⬇️
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/debug/apply_transforms.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/debug/transform.go 95.91% <ø> (ø)
pkg/skaffold/docker/logger/log.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/kubectl/exec.go 100.00% <ø> (ø)
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d306e4...e544d0a. Read the comment docs.

@verbanicm verbanicm added the kokoro:force-run forces a kokoro re-run on a PR label Sep 9, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 9, 2021
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@tejal29 tejal29 merged commit cef958a into GoogleContainerTools:main Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist V2 logs in a file if --event-log-file is present
3 participants