Create port map on container config if empty #6621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandealwis
approved these changes
Sep 21, 2021
nkubala
force-pushed
the
docker-port-fix
branch
from
c9a591d to
06d02e7
Compare
nkubala
changed the title
|
@briandealwis @tejal29 I had intentionally left that blank file here as a reminder that test cases needed to be added (so CI would fail until they were), but I realized that there were existing (broken) test cases for this. they're now fixed and this should be ready for a look |
Codecov Report
@@ Coverage Diff @@
## main #6621 +/- ##
==========================================
- Coverage 70.48% 70.13% -0.35%
==========================================
Files 515 520 +5
Lines 23150 23614 +464
==========================================
+ Hits 16317 16562 +245
- Misses 5776 5973 +197
- Partials 1057 1079 +22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a nil pointer exception when the container didn't have previously defined ports in its config.
This was not caught by tests because these tests were actually silently broken - a
debuglevel log message was being emitted saying these port forward resources were being skipped because they were not of resource typecontainer. Upon adding this to the tests cases, this test failed as expected.