Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preliminary support for Config Connector service KRM #6645

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

briandealwis
Copy link
Member

Related: #6629

Description
Add support for Config Connector's preliminary Service type. As the exact group is still TBD, add support for wildcarded group/kinds. The wildcards are expressed using regexps to avoid taking on a dependency for a glob package.

Follow-up Work (remove if N/A)
The group should be filled in at some point once it is settled.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #6645 (77e8402) into main (290280e) will decrease coverage by 0.46%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6645      +/-   ##
==========================================
- Coverage   70.48%   70.01%   -0.47%     
==========================================
  Files         515      522       +7     
  Lines       23150    23712     +562     
==========================================
+ Hits        16317    16602     +285     
- Misses       5776     6025     +249     
- Partials     1057     1085      +28     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
pkg/skaffold/build/jib/errors.go 48.93% <50.00%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
pkg/diag/validator/resource.go 47.05% <66.66%> (ø)
pkg/skaffold/build/docker/docker.go 86.44% <66.66%> (-2.85%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151b8d3...77e8402. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For related Future Work, do any docs need to be updated as well? Might make sense to make an issue or track that somewhere.

@briandealwis
Copy link
Member Author

#6629 can serve that purpose.

@briandealwis briandealwis merged commit ecd662e into GoogleContainerTools:main Sep 30, 2021
@briandealwis briandealwis deleted the cc-krm branch September 30, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants