Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use gcloud spec pool instead of deprecated WorkerPool #6658

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 30, 2021

The field WorkerPool is deprecated since v0.50.0 in CloudBuild API
https://github.com/googleapis/google-api-go-client/blob/v0.58.0/cloudbuild/v1alpha1/cloudbuild-gen.go#L744

Switching to PoolOption in the Cloud Build Spec.

@tejal29 tejal29 requested a review from a team as a code owner September 30, 2021 23:45
@tejal29 tejal29 requested a review from gsquared94 September 30, 2021 23:45
@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #6658 (7f8bcf4) into main (290280e) will decrease coverage by 0.49%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6658      +/-   ##
==========================================
- Coverage   70.48%   69.99%   -0.50%     
==========================================
  Files         515      522       +7     
  Lines       23150    23740     +590     
==========================================
+ Hits        16317    16616     +299     
- Misses       5776     6039     +263     
- Partials     1057     1085      +28     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
pkg/diag/validator/resource.go 47.05% <66.66%> (ø)
pkg/skaffold/build/docker/docker.go 86.44% <66.66%> (-2.85%) ⬇️
pkg/skaffold/build/docker/errors.go 63.33% <80.00%> (-2.23%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26dc1b8...7f8bcf4. Read the comment docs.

@tejal29 tejal29 merged commit bc3824b into main Oct 1, 2021
@tejal29 tejal29 deleted the fix_deprecated_worker_pool branch October 1, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants