fix: Sanitize image names when default repo unset #6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that image names from `skaffold.yaml` are sanitized even when the Skaffold default repo is not set. This is relevant for ko images with names that consist of the `ko://` scheme prefixed, followed by a Go import path that may contain uppercase characters, e.g., `ko://github.com/GoogleContainerTools/skaffold/cmd/skaffold`. Fixes: GoogleContainerTools#6675 Tracking: GoogleContainerTools#6041 Related: GoogleContainerTools#4952
Codecov Report
@@ Coverage Diff @@
## main #6678 +/- ##
==========================================
- Coverage 70.48% 69.80% -0.69%
==========================================
Files 515 523 +8
Lines 23150 23834 +684
==========================================
+ Hits 16317 16637 +320
- Misses 5776 6112 +336
- Partials 1057 1085 +28
Continue to review full report at Codecov.
|
tejal29
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that image names from
skaffold.yamlare sanitized even when the Skaffold default repo is not set.This is relevant for ko images with names that consist of the
ko://scheme prefixed, followed by a Go import path that may contain uppercase characters, e.g.,ko://github.com/GoogleContainerTools/skaffold/cmd/skaffold.Fixes: #6675
Tracking: #6041
Related: #4952