Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 30 min timeout for integration tests #6684

Merged

Conversation

halvards
Copy link
Contributor

@halvards halvards commented Oct 6, 2021

Description
Integration tests on Kokoro either pass within 20-24 minutes, or TestDevGracefulCancel hangs until the build times out.

A shorter timeout would help us by failing builds that hang sooner.

Related: #6424, #6643, #6662

Kokoro integration tests either pass within 20-24 minutes, or
`TestDevGracefulCancel` hangs until the build times out.

A shorter timeout would help us by failing builds that hang sooner.
@halvards halvards requested a review from a team as a code owner October 6, 2021 02:35
@halvards halvards requested a review from MarlonGamez October 6, 2021 02:35
@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@halvards halvards added the kokoro:run runs the kokoro jobs on a PR label Oct 6, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #6684 (e80017b) into main (290280e) will decrease coverage by 0.69%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6684      +/-   ##
==========================================
- Coverage   70.48%   69.79%   -0.70%     
==========================================
  Files         515      523       +8     
  Lines       23150    23835     +685     
==========================================
+ Hits        16317    16635     +318     
- Misses       5776     6113     +337     
- Partials     1057     1087      +30     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
pkg/diag/validator/resource.go 47.05% <66.66%> (ø)
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
pkg/skaffold/build/buildpacks/lifecycle.go 83.59% <100.00%> (ø)
pkg/skaffold/initializer/build/builders.go 42.85% <0.00%> (-17.15%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86da7e7...e80017b. Read the comment docs.

@tejal29
Copy link
Contributor

tejal29 commented Oct 6, 2021

I like the 30 min timeout!

@MarlonGamez MarlonGamez merged commit 450a239 into GoogleContainerTools:main Oct 6, 2021
tejal29 added a commit that referenced this pull request Feb 17, 2022
tejal29 added a commit that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants