Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ad-hoc signing on darwin to avoid network popups #6738

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

briandealwis
Copy link
Member

Add a codesign step to sign the Skaffold binary with an ad-hoc signature. This seems to avoid the macOS prompts to accept incoming network connections.

unnamed

@briandealwis briandealwis requested a review from a team as a code owner October 18, 2021 14:39
@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #6738 (58f5547) into main (290280e) will decrease coverage by 0.82%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6738      +/-   ##
==========================================
- Coverage   70.48%   69.65%   -0.83%     
==========================================
  Files         515      527      +12     
  Lines       23150    24096     +946     
==========================================
+ Hits        16317    16784     +467     
- Misses       5776     6209     +433     
- Partials     1057     1103      +46     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 64.17% <100.00%> (ø)
pkg/skaffold/initializer/build/builders.go 42.85% <0.00%> (-17.15%) ⬇️
pkg/skaffold/build/cluster/logs.go 0.00% <0.00%> (-16.67%) ⬇️
pkg/skaffold/event/v2/status_check.go 85.45% <0.00%> (-14.55%) ⬇️
pkg/skaffold/kubernetes/watcher.go 67.10% <0.00%> (-14.53%) ⬇️
.../skaffold/kubernetes/status/resource/deployment.go 72.41% <0.00%> (-13.39%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fa82d...58f5547. Read the comment docs.

@MarlonGamez MarlonGamez merged commit f47aa41 into GoogleContainerTools:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants