Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: status-check for stateful sets #6828

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes: #6644
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

@gsquared94 gsquared94 requested a review from a team as a code owner November 10, 2021 17:36
@gsquared94 gsquared94 requested a review from nkubala November 10, 2021 17:36
@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #6828 (7e43386) into main (290280e) will decrease coverage by 1.29%.
The diff coverage is 64.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6828      +/-   ##
==========================================
- Coverage   70.48%   69.18%   -1.30%     
==========================================
  Files         515      547      +32     
  Lines       23150    25007    +1857     
==========================================
+ Hits        16317    17301     +984     
- Misses       5776     6549     +773     
- Partials     1057     1157     +100     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
cmd/skaffold/app/cmd/inspect_build_env.go 65.11% <75.00%> (+6.39%) ⬆️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471624f...7e43386. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status check should monitor stateful set resources
2 participants