Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply cmd should run kubectl create --dry-run to get the ManifestList #6875

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes: #6870

@gsquared94 gsquared94 requested a review from nkubala November 18, 2021 12:37
@gsquared94 gsquared94 requested a review from a team as a code owner November 18, 2021 12:37
@google-cla google-cla bot added the cla: yes label Nov 18, 2021
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #6875 (fc5dd52) into main (290280e) will decrease coverage by 1.33%.
The diff coverage is 61.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6875      +/-   ##
==========================================
- Coverage   70.48%   69.14%   -1.34%     
==========================================
  Files         515      547      +32     
  Lines       23150    25080    +1930     
==========================================
+ Hits        16317    17342    +1025     
- Misses       5776     6575     +799     
- Partials     1057     1163     +106     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f56bbd...fc5dd52. Read the comment docs.

@gsquared94 gsquared94 enabled auto-merge (squash) November 18, 2021 13:11
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@gsquared94 gsquared94 merged commit d804dcd into GoogleContainerTools:main Nov 18, 2021
tejal29 pushed a commit that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold apply deployments never stabilize on Skaffold 1.35
2 participants